Issue1139 add nunit4 tests #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharliePoole
approved these changes
Feb 22, 2022
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="NUnit" Version="4.0.0-dev-07273" /> |
There was a problem hiding this comment.
I like that you specify an exact build here, to avoid errors due to changes in the framework project. It would be nice to use a property, based no a constant we define more prominently at the top level, but that's probably best for a latter improvement.
|
@manfred-brands I sent you an invitation to join the engine team. If you have questions, feel free to contact me offline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139
First commit is to find a preview version of VS2022 when VS2019 is installed.
The code should preferably throw if it can't find MSBuild 17.0 as the .NET 6 sdk complains it it is run with MSBuild 15.0
Also update the minimum requirement in BUILDING.md
Second commit adds mock-assembly-nunit4 and associated tests.